Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definition LPS33HW #469

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Add definition LPS33HW #469

merged 1 commit into from
Aug 28, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Aug 16, 2023 •
edited
Loading

Adds definition for LPS33HW Ported water resistant pressure sensor.
https://www.adafruit.com/product/4414

DRAFT STATUS - Not to be merged before definition added!

@tyeth tyeth mentioned this pull request Aug 16, 2023
Merged
@brentru
Copy link
Member

brentru commented Aug 16, 2023

Definition #142 is added.

@tyeth tyeth marked this pull request as ready for review August 16, 2023 16:03
@tyeth
Copy link
Contributor Author

tyeth commented Aug 16, 2023

@brentru Retested from CI build
image

@tyeth tyeth requested a review from brentru August 16, 2023 16:34
@brentru
Copy link
Member

brentru commented Aug 16, 2023

failing on feather_esp8266?

@tyeth
Copy link
Contributor Author

tyeth commented Aug 16, 2023

failing on feather_esp8266?

Strange, it ran through eventually 9hrs ago. Only rebased.

@brentru
Copy link
Member

brentru commented Aug 21, 2023

@tyeth Try merging #474 into this branch to pass CI

@tyeth
Copy link
Contributor Author

tyeth commented Aug 21, 2023 •
edited
Loading

@brentru still failed first run on the C3 with zero build output. Was second of 3 rapid rebases.
Maybe worth considering wretry(Wandalen/wretry.action#108) after all, was thinking set a retry count of two per task as CI failing quickly twice is probably okay, maybe someone knows of a better retry solution or fix for the spurious arduino build timeout/failure.

@brentru
Copy link
Member

brentru commented Aug 28, 2023

@tyeth Ok! We'll talk about the Arduino retry issue this week. This is currently passing - can I merge in?

@tyeth
Copy link
Contributor Author

tyeth commented Aug 28, 2023

@brentru good to merge 👍

@brentru brentru merged commit 7084552 into adafruit:main Aug 28, 2023
24 checks passed
@tyeth tyeth deleted the add-LPS33HW branch September 19, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru Awaiting requested review from brentru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyeth @brentru